y1chi commented on a change in pull request #12808: URL: https://github.com/apache/beam/pull/12808#discussion_r486481259
########## File path: sdks/python/apache_beam/testing/benchmarks/nexmark/README.md ########## @@ -0,0 +1,57 @@ +<!-- + Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, + software distributed under the License is distributed on an + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + KIND, either express or implied. See the License for the + specific language governing permissions and limitations + under the License. +--> + +# how to Run Python Nexmark + +## Batch Mode + +For batch mode, a file needs to be generated first by running java suite and writing events to a file. Review comment: Could you also add the step or code snippet to generate the file? ########## File path: sdks/python/apache_beam/testing/benchmarks/nexmark/README.md ########## @@ -0,0 +1,57 @@ +<!-- + Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, + software distributed under the License is distributed on an + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + KIND, either express or implied. See the License for the + specific language governing permissions and limitations + under the License. +--> + +# how to Run Python Nexmark Review comment: `How to run a python nexmark benchmark` ########## File path: sdks/python/apache_beam/testing/benchmarks/nexmark/README.md ########## @@ -0,0 +1,57 @@ +<!-- + Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, + software distributed under the License is distributed on an + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + KIND, either express or implied. See the License for the + specific language governing permissions and limitations + under the License. +--> + +# how to Run Python Nexmark + +## Batch Mode + +For batch mode, a file needs to be generated first by running java suite and writing events to a file. + +### Direct Runner + +```shell script +python nexmark_launcher.py --query 5 --num_events 10000 --runner DirectRunner --input PATH_TO_INPUT_FILE +``` + +### Dataflow Runner + +```shell script +python nexmark_launcher.py --query 5 --num_events 100000 --runner DataflowRunner --project PROJECT_NAME --region YOUR_REGION --temp_location TEMP_LOCATION --staging_location STAGING_LOCATION --sdk_location SDK_LOCATION --input PATH_TO_INPUT_FILE_ON_GS +``` + +## Streaming mode + +First generate and publish events to pubsub using java nexmark suite: Review comment: ```suggestion First generate and publish events to pubsub using java nexmark suite, example: ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
