claudevdm commented on code in PR #35243:
URL: https://github.com/apache/beam/pull/35243#discussion_r2161580240
##########
sdks/python/apache_beam/io/external/xlang_jdbcio_it_test.py:
##########
@@ -255,10 +253,6 @@ def test_xlang_jdbc_write_read(self, database):
classpath=config['classpath'],
))
- # Register MillisInstant logical type to override the mapping from
Timestamp
- # originally handled by MicrosInstant.
- LogicalType.register_logical_type(MillisInstant)
Review Comment:
The way I understand it is your fix avoids the need for using this to
workaround to work withdate (beam:logical_type:javasdk_date:v1) and time
(beam:logical_type:javasdk_time:v1) types.
For jdbc timestamp types, java encodes as
beam:logical_type:millis_instant:v1, which python interprets as a language type
Timestamp, but MicrosInstant is registered to handle timestamps?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
