damccorm commented on PR #35197: URL: https://github.com/apache/beam/pull/35197#issuecomment-2997397422
> > > I’ve noticed that wherever this module is used, the Beam pipeline is skipping those tests > > > > > > @pandasanjay I found it depends mostly on the GitHub runner/workflow those tests run on. I have recently come across this when I have been working on Milvus Enrichment Handler #35216. > > Using try-except on the related imports that need dependencies and skipping that test would solve the issue. That being said, I think it may change from case to case, so someone may check that this happens on specific workflows, not all. Otherwise, those test cases would never run since they are entirely skipped. > > @mohamedawnallah I’ve noticed the same issue and even used that approach to fix my integration tests. However, it seems that all the example tests are failing at that point in the GitHub Actions workflow, which raises the question of whether this module has ever been successfully installed and run via GitHub Actions. This aligns with your last point. > > I think we could use some guidance on how to proceed here. Generally skipping if dependencies are not present is the recommended path. Some tests will only run as postcommits (e.g. see conversation in https://github.com/apache/beam/pull/35395) In this case since we're just blocking on GCP dependencies which should get installed as part of the postcommit runs - you should be able to run the python postcommit following https://github.com/apache/beam/blob/master/.github/workflows/README.md#workflow-triggers as part of this pr (you would modify https://github.com/apache/beam/blob/master/.github/trigger_files/beam_PostCommit_Python.json). Its always a good idea to make sure tests actually run when they get added -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
