lukecwik commented on a change in pull request #12806:
URL: https://github.com/apache/beam/pull/12806#discussion_r486549559
##########
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsub/PubsubIO.java
##########
@@ -1012,6 +1012,8 @@ public PDone expand(PCollection<T> input) {
case UNBOUNDED:
return input
.apply(MapElements.into(new TypeDescriptor<PubsubMessage>()
{}).via(getFormatFn()))
+ // TODO(BEAM-10869): Also plump through
PubsubMessageWithAttributesCoder if needed.
+ .setCoder(PubsubMessagePayloadOnlyCoder.of())
Review comment:
Won't this break pipeline update?
Also, the implementation only uses the payload so I don't think we need the
TODO since we don't use any of the other attributes from the message so we can
leave a comment here stating instead that the unbounded sink only uses the
payload of the pubsub message.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
