shunping commented on code in PR #35412: URL: https://github.com/apache/beam/pull/35412#discussion_r2164781118
########## sdks/python/apache_beam/transforms/periodicsequence.py: ########## @@ -91,7 +94,39 @@ class ImpulseSeqGenDoFn(beam.DoFn): ImpulseSeqGenDoFn can't guarantee that each element is output at exact time. ImpulseSeqGenDoFn guarantees that elements would not be output prior to given runtime timestamp. + + The output mode of the DoFn is based on the input `data`: + + - **None**: If `data` is None (by default), the output element will be the Review Comment: Sure. But notice that this will introduce a breaking change on the pipeline DAG. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
