rohdesamuel commented on a change in pull request #12704:
URL: https://github.com/apache/beam/pull/12704#discussion_r486566707
##########
File path: sdks/python/apache_beam/runners/interactive/interactive_beam.py
##########
@@ -342,121 +343,79 @@ def show(*pcolls, **configs):
assert isinstance(pcoll, beam.pvalue.PCollection), (
'{} is not an apache_beam.pvalue.PCollection.'.format(pcoll))
user_pipeline = pcolls[0].pipeline
- for pcoll in pcolls:
- assert pcoll.pipeline is user_pipeline, (
- '{} belongs to a different user-defined pipeline ({}) than that of'
- ' other PCollections ({}).'.format(
- pcoll, pcoll.pipeline, user_pipeline))
+
# TODO(BEAM-8288): Remove below pops and assertion once Python 2 is
# deprecated from Beam.
include_window_info = configs.pop('include_window_info', False)
visualize_data = configs.pop('visualize_data', False)
+ n = configs.pop('n', 'inf')
+ duration = configs.pop('duration', 'inf')
+
+ if n == 'inf':
+ n = float('inf')
+
+ if duration == 'inf':
+ duration = float('inf')
Review comment:
Added assertions
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
