liferoad commented on code in PR #35472:
URL: https://github.com/apache/beam/pull/35472#discussion_r2175826151


##########
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/BeamSqlPipelineOptions.java:
##########
@@ -30,6 +30,11 @@ public interface BeamSqlPipelineOptions extends 
PipelineOptions {
 
   void setPlannerName(String className);
 
+  @Description("The dialect of calcite connection.")
+  String getCalciteConnectionDialect();
+
+  void setCalciteConnectionDialect(String dialect);
+

Review Comment:
   I like your idea. Done. and also added your test. Thanks for helping!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to