scwhittle commented on code in PR #35327:
URL: https://github.com/apache/beam/pull/35327#discussion_r2178266320
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/windmill/client/grpc/GrpcCommitWorkStream.java:
##########
@@ -230,10 +271,13 @@ private void issueSingleRequest(long id, PendingRequest
pendingRequest)
.setSerializedWorkItemCommit(pendingRequest.serializedCommit());
StreamingCommitWorkRequest chunk = requestBuilder.build();
synchronized (this) {
- if (!prepareForSend(id, pendingRequest)) {
+ if (isShutdown) {
pendingRequest.abort();
Review Comment:
oops, didn't mean to remove that. I added more test coverage. It didn't
matter before since the trySend would just fail and after shutdown things in
pending didn't make a difference. But still good to fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
