ahmedabu98 commented on code in PR #35496:
URL: https://github.com/apache/beam/pull/35496#discussion_r2178388362


##########
sdks/java/io/iceberg/src/main/java/org/apache/beam/sdk/io/iceberg/IcebergCatalogConfig.java:
##########
@@ -84,17 +84,26 @@ public org.apache.iceberg.catalog.Catalog catalog() {
   }
 
   public void createTable(
-      String tableIdentifier, Schema tableSchema, @Nullable List<String> 
partitionFields) {
+      String tableIdentifier,

Review Comment:
   This method is used by Beam SQL's `CREATE TABLE ...` command. 
   
   Let's revert these changes for now, we can add integration with Beam SQL 
later



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to