ryan-mbuashundip commented on code in PR #35391:
URL: https://github.com/apache/beam/pull/35391#discussion_r2190695684
##########
sdks/python/apache_beam/options/pipeline_options.py:
##########
@@ -1381,6 +1381,14 @@ def _add_argparse_args(cls, parser):
'responsible for executing the user code and communicating with '
'the runner. Depending on the runner, there may be more than one '
'SDK Harness process running on the same worker node.'))
+ parser.add_argument(
+ '--element_processing_timeout',
Review Comment:
Please add the unit of the flag to the name, e.g.,
`element_processing_timeout_minutes`.
##########
sdks/python/apache_beam/runners/worker/sdk_worker.py:
##########
@@ -409,6 +416,10 @@ def create_worker(self):
return SdkWorker(
self._bundle_processor_cache, profiler_factory=self._profiler_factory)
+ def _shutdown_due_to_element_processing_timeout(self, errMsg: str) -> None:
+ _LOGGER.error('%sThe SDK harness will be terminated.', errMsg)
Review Comment:
Keep just one of the messages about the SDK harness terminated here and
where the `TimeoutError` is caught, having both is redundant.
##########
sdks/python/apache_beam/runners/worker/worker_status.py:
##########
@@ -47,6 +47,8 @@
# 5 minutes * 60 seconds * 1000 millis * 1000 micros * 1000 nanoseconds
DEFAULT_LOG_LULL_TIMEOUT_NS = 5 * 60 * 1000 * 1000 * 1000
+DEFAULT_RESTART_LULL_TIMEOUT_NS = 10 * 60 * 1000 * 1000 * 1000
Review Comment:
Lower bound isn't necessary, see
https://github.com/apache/beam/pull/35120/files#r2171479595.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
