claudevdm commented on code in PR #35533:
URL: https://github.com/apache/beam/pull/35533#discussion_r2197974988
##########
sdks/python/apache_beam/io/gcp/bigquery.py:
##########
@@ -2723,11 +2723,12 @@ def expand(self, input):
lambda row_and_error: row_and_error[0])
if not is_rows:
# return back from Beam Rows to Python dict elements
- failed_rows = failed_rows | beam.Map(lambda row: row.as_dict())
+ failed_rows = failed_rows | beam.Map(
+ lambda row: getattr(row, 'as_dict', row._asdict)())
Review Comment:
Thanks for the fix. If my understanding is correct here, the type returned
from the java cross language transform is a NamedTuple, and therefore `as_dict`
does not exist.
Is there any case where the returned type is not a NamedTuple? If not, can
we just use `_as_dict` without checking for `as_dict`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
