Abacn commented on code in PR #35559:
URL: https://github.com/apache/beam/pull/35559#discussion_r2204883893


##########
sdks/python/tox.ini:
##########
@@ -307,6 +307,7 @@ commands =
   bash {toxinidir}/scripts/pytest_validates_runner.sh {envname} 
{toxinidir}/apache_beam/runners/portability/flink_runner_test.py {posargs}
 
 [testenv:samza-runner-test]
+passenv = JAVA_HOME

Review Comment:
   Tried in previous commits and it caused test failures, e.g. 
https://github.com/apache/beam/actions/runs/16206520294/job/45760251935
   
   I didn't fully understand how this happened, as the error
   
   ```
   Caused by: java.io.IOException: Received exit code 125 for command 'docker 
run -d --mount 
type=bind,src=/home/runner/.config/gcloud,dst=/root/.config/gcloud 
--network=host --env=DOCKER_MAC_CONTAINER=null 
apache/beam_java11_sdk:2.67.0.dev --id=59-10 
--provision_endpoint=localhost:35701'. stderr: docker: Error response from 
daemon: invalid mount config for type "bind": bind source path does not exist: 
/home/runner/.config/gcloud.See 'docker run --help'.
        at 
org.apache.beam.runners.fnexecution.environment.DockerCommand.runShortCommand(DockerCommand.java:255)
        at 
org.apache.beam.runners.fnexecution.environment.DockerCommand.runShortCommand(DockerCommand.java:181)
   ```
   came from Java side.
   
   Moreover beam_PreCommit_Python_PVR_Flink does not set testJavaVersion and 
JAVA_HOME. Reverted the change in the final commit and leave this for future 
investigation



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to