damccorm commented on code in PR #35107: URL: https://github.com/apache/beam/pull/35107#discussion_r2205454664
########## infra/users.yml: ########## @@ -0,0 +1,493 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +# This file contains a list of users and their permissions in the GCP project. +# Structure: +# - username: <username> +# email: <email> +# permissions: +# - role: <role> +# title: <title> (optional) +# description: <description> (optional) +# expiry_date: <expiry_date> (optional, format: YYYY-MM-DD) +# - role: <role> (optional, for multiple roles) +# The roles are defined in the GCP project `PROJECT-ID` under the `roles` directory. + +--- +- username: WhatWouldAustinDo + email: whatwouldausti...@gmail.com + permissions: + - role: projects/PROJECT-ID/roles/beam_infra_manager + - role: projects/PROJECT-ID/roles/beam_viewer +- username: aaronleeiv + email: aaronle...@google.com + permissions: + - role: projects/PROJECT-ID/roles/beam_infra_manager + - role: projects/PROJECT-ID/roles/beam_viewer +- username: abbymotley + email: abbymot...@google.com + permissions: + - role: projects/PROJECT-ID/roles/beam_infra_manager + - role: projects/PROJECT-ID/roles/beam_viewer +- username: ahmedabualsaud + email: ahmedabuals...@google.com + permissions: + - role: roles/owner +- username: akarys.akvelon + email: akarys.akve...@gmail.com + permissions: + - role: projects/PROJECT-ID/roles/beam_admin + - role: projects/PROJECT-ID/roles/beam_infra_manager + - role: projects/PROJECT-ID/roles/beam_viewer +- username: aleksandr.dudko + email: aleksandr.du...@akvelon.com + permissions: + - role: projects/PROJECT-ID/roles/beam_admin + - role: projects/PROJECT-ID/roles/beam_infra_manager + - role: projects/PROJECT-ID/roles/beam_viewer +- username: alex.kosolapov + email: alex.kosola...@akvelon.com + permissions: + - role: projects/PROJECT-ID/roles/beam_infra_manager + - role: projects/PROJECT-ID/roles/beam_viewer +- username: alexey.inkin + email: alexey.in...@akvelon.com + permissions: + - role: projects/PROJECT-ID/roles/beam_infra_manager + - role: projects/PROJECT-ID/roles/beam_viewer +- username: altay + email: al...@google.com + permissions: + - role: roles/owner +- username: anandinguva + email: ananding...@google.com + permissions: + - role: projects/PROJECT-ID/roles/beam_infra_manager + - role: projects/PROJECT-ID/roles/beam_viewer +- username: andres.vervaecke + email: andres.vervae...@ml6.eu + permissions: + - role: projects/PROJECT-ID/roles/beam_infra_manager + - role: projects/PROJECT-ID/roles/beam_viewer +- username: andrey.devyatkin + email: andrey.devyat...@akvelon.com + permissions: + - role: roles/owner +- username: anikin + email: ani...@google.com + permissions: + - role: projects/PROJECT-ID/roles/beam_infra_manager + - role: projects/PROJECT-ID/roles/beam_viewer +- username: arne.vandendorpe + email: arne.vandendo...@ml6.eu + permissions: + - role: projects/PROJECT-ID/roles/beam_infra_manager + - role: projects/PROJECT-ID/roles/beam_viewer +- username: aroraarnav + email: aroraar...@google.com + permissions: + - role: roles/owner +- username: asfgnome + email: asfgn...@gmail.com + permissions: + - role: roles/owner +- username: bjornpedersen + email: bjornpeder...@google.com + permissions: + - role: projects/PROJECT-ID/roles/beam_infra_manager + - role: projects/PROJECT-ID/roles/beam_viewer +- username: bvolpato + email: bvolp...@google.com + permissions: + - role: projects/PROJECT-ID/roles/beam_infra_manager + - role: projects/PROJECT-ID/roles/beam_viewer +- username: byronellis + email: byronel...@google.com + permissions: + - role: roles/owner +- username: ccychenzo + email: ccyche...@gmail.com + permissions: + - role: projects/PROJECT-ID/roles/beam_infra_manager + - role: projects/PROJECT-ID/roles/beam_viewer +- username: chamikara + email: chamik...@google.com + permissions: + - role: roles/owner +- username: cloud-data-workflow-dev + email: cloud-data-workflow-...@prod.google.com + permissions: + - role: projects/PROJECT-ID/roles/beam_infra_manager + - role: projects/PROJECT-ID/roles/beam_viewer +- username: cvandermerwe + email: cvanderme...@google.com + permissions: + - role: projects/PROJECT-ID/roles/beam_infra_manager + - role: projects/PROJECT-ID/roles/beam_viewer +- username: damondouglas + email: damondoug...@google.com + permissions: + - role: roles/owner +- username: dannymccormick + email: dannymccorm...@google.com + permissions: + - role: roles/owner +- username: dcrhodes + email: dcrho...@google.com + permissions: + - role: projects/PROJECT-ID/roles/beam_viewer Review Comment: This doesn't seem to be the correct permission set. <img width="846" height="57" alt="image" src="https://github.com/user-attachments/assets/914184df-4aef-40c7-96d8-1e6bd3aaafe9"; /> I did a quick audit and this was one of the first few accounts I looked at, so I expect there are other changes in permissions ########## infra/config.auto.tfvars: ########## @@ -0,0 +1,21 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +# This file is used for general configuration of the Terraform project, + +# GCP Project ID +project_id = "testing-me-460223" Review Comment: ```suggestion project_id = "apache-beam-testing" ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
