mohamedawnallah commented on code in PR #35598:
URL: https://github.com/apache/beam/pull/35598#discussion_r2208235235
##########
.github/workflows/beam_PostCommit_Python.yml:
##########
@@ -107,8 +107,8 @@ jobs:
-PuseWheelDistribution \
-Pposargs="${{
contains(matrix.os, 'self-hosted') &&
- '-m ''not require_non_self_hosted''' ||
- '-m ''require_non_self_hosted'''
+ '-m ''not require_docker_in_docker''' ||
+ '-m ''require_docker_in_docker'''
}}" \
Review Comment:
I am not sure if the updated `Pposargs` are maintainable and extendable in
the future incase if there are other environmental constrains in the future. I
feel like `require_non_self_hosted` would be more extendable...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
