mohamedawnallah commented on code in PR #35598:
URL: https://github.com/apache/beam/pull/35598#discussion_r2208480910
##########
.github/workflows/beam_PreCommit_Python_ML.yml:
##########
@@ -104,8 +104,8 @@ jobs:
arguments: |
-Pposargs="${{
contains(matrix.os, 'self-hosted') &&
- 'apache_beam/ml/ -m ''not require_non_self_hosted''' ||
- 'apache_beam/ml/ -m ''require_non_self_hosted'''
+ 'apache_beam/ml/ -m ''not require_docker_in_docker''' ||
+ 'apache_beam/ml/ -m ''require_docker_in_docker'''
Review Comment:
I've also another approach of just using `-k` instead `-m` for keyword
matching but I think your approach is more reliable in the future
```bash
(.venv) dev@dev:~/beam_dev/beam/sdks/python/apache_beam/ml/rag/enrichment$
pytest -v -k "require_docker_in_docker"
--test-pipeline-options="--runner=DirectRunner"
====================================================== test session starts
=======================================================
platform linux -- Python 3.9.22, pytest-7.4.4, pluggy-1.6.0 --
/home/dev/beam_dev/beam/sdks/python/.venv/bin/python
cachedir: .pytest_cache
hypothesis profile 'default'
rootdir: /home/dev/beam_dev/beam/sdks/python
configfile: pytest.ini
plugins: xdist-3.8.0, requests-mock-1.12.1, timeout-2.4.0, anyio-4.9.0,
hypothesis-6.135.31
timeout: 600.0s
timeout method: signal
timeout func_only: False
collected 36 items / 27 deselected / 9 selected
milvus_search_it_test.py::TestMilvusSearchEnrichment::test_empty_input_chunks
PASSED [ 11%]
milvus_search_it_test.py::TestMilvusSearchEnrichment::test_filtered_search_with_bm25_full_text_and_batching
PASSED [ 22%]
milvus_search_it_test.py::TestMilvusSearchEnrichment::test_filtered_search_with_cosine_similarity_and_batching
PASSED [ 33%]
milvus_search_it_test.py::TestMilvusSearchEnrichment::test_hybrid_search
PASSED [ 44%]
milvus_search_it_test.py::TestMilvusSearchEnrichment::test_invalid_query_on_non_existent_collection
PASSED [ 55%]
milvus_search_it_test.py::TestMilvusSearchEnrichment::test_invalid_query_on_non_existent_field
PASSED [ 66%]
milvus_search_it_test.py::TestMilvusSearchEnrichment::test_keyword_search_with_inner_product_sparse_embedding
PASSED [ 77%]
milvus_search_it_test.py::TestMilvusSearchEnrichment::test_vector_search_with_euclidean_distance
PASSED [ 88%]
milvus_search_it_test.py::TestMilvusSearchEnrichment::test_vector_search_with_inner_product_similarity
PASSED [100%]
=============================================== 9 passed, 27 deselected in
30.26s ================================================
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
