derrickaw commented on code in PR #35375:
URL: https://github.com/apache/beam/pull/35375#discussion_r2211150667
##########
sdks/python/apache_beam/yaml/examples/testing/examples_test.py:
##########
@@ -140,15 +157,62 @@ def test_pubsub_read(
pubsub_messages = input_data.pubsub_messages_data()
return (
- pbegin
+ pcoll
| beam.Create([json.loads(msg.data) for msg in pubsub_messages])
| beam.Map(lambda element: beam.Row(**element)))
+@beam.ptransform.ptransform_fn
+def test_run_inference(pcoll, inference_tag, model_handler):
+ """
+ This PTransform simulates the behavior of the RunInference transform.
+
+ Args:
+ pcoll: The input PCollection.
+ inference_tag: The tag to use for the returned inference.
+ model_handler: A configuration for the respective ML model handler
+
+ Returns:
+ A PCollection containing the enriched data.
+ """
+
+ from apache_beam.ml.inference.base import PredictionResult
+ from apache_beam.typehints.row_type import RowTypeConstraint
Review Comment:
Lets put the imports at the top
##########
sdks/python/apache_beam/yaml/examples/testing/examples_test.py:
##########
@@ -140,15 +157,62 @@ def test_pubsub_read(
pubsub_messages = input_data.pubsub_messages_data()
return (
- pbegin
+ pcoll
| beam.Create([json.loads(msg.data) for msg in pubsub_messages])
| beam.Map(lambda element: beam.Row(**element)))
+@beam.ptransform.ptransform_fn
+def test_run_inference(pcoll, inference_tag, model_handler):
+ """
+ This PTransform simulates the behavior of the RunInference transform.
+
+ Args:
+ pcoll: The input PCollection.
+ inference_tag: The tag to use for the returned inference.
+ model_handler: A configuration for the respective ML model handler
+
+ Returns:
+ A PCollection containing the enriched data.
+ """
+
+ from apache_beam.ml.inference.base import PredictionResult
+ from apache_beam.typehints.row_type import RowTypeConstraint
Review Comment:
Lets put the imports at the top of file
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
