ahmedabu98 commented on code in PR #35435:
URL: https://github.com/apache/beam/pull/35435#discussion_r2214044302
##########
sdks/python/apache_beam/yaml/integration_tests.py:
##########
@@ -753,14 +753,16 @@ def parse_test_files(filepattern):
For example, 'path/to/tests/*.yaml'.
"""
for path in glob.glob(filepattern):
- with open(path) as fin:
- suite_name = os.path.splitext(os.path.basename(path))[0].title().replace(
- '-', '') + 'Test'
- print(path, suite_name)
- methods = dict(
- create_test_methods(
- yaml.load(fin, Loader=yaml_transform.SafeLineLoader)))
- globals()[suite_name] = type(suite_name, (unittest.TestCase, ), methods)
+ if "bigtable" in path:
+ with open(path) as fin:
+ suite_name = os.path.splitext(
+ os.path.basename(path))[0].title().replace('-', '') + 'Test'
+ print(path, suite_name)
+ methods = dict(
+ create_test_methods(
+ yaml.load(fin, Loader=yaml_transform.SafeLineLoader)))
+ globals()[suite_name] = type(
+ suite_name, (unittest.TestCase, ), methods)
Review Comment:
undo?
##########
sdks/python/apache_beam/yaml/standard_io.yaml:
##########
@@ -371,3 +371,27 @@
'WriteToTFRecord':
'beam:schematransform:org.apache.beam:tfrecord_write:v1'
config:
gradle_target: 'sdks:java:io:expansion-service:shadowJar'
+
+#BigTable
+- type: renaming
+ transforms:
+ 'ReadFromBigTable': 'ReadFromBigTable'
+ 'WriteToBigTable': 'WriteToBigTable'
+ config:
+ mappings:
+ 'ReadFromBigTable':
+ project: 'project_Id'
+ instance: 'instanceId'
+ table: 'tableId'
+ 'WriteToBigTable':
+ project: 'project_id'
+ instance: 'instance_id'
+ table: 'table_id'
+ Rows: "rows"
Review Comment:
@arnavarora2004
##########
sdks/python/apache_beam/yaml/standard_io.yaml:
##########
@@ -371,3 +371,27 @@
'WriteToTFRecord':
'beam:schematransform:org.apache.beam:tfrecord_write:v1'
config:
gradle_target: 'sdks:java:io:expansion-service:shadowJar'
+
+#BigTable
+- type: renaming
+ transforms:
+ 'ReadFromBigTable': 'ReadFromBigTable'
+ 'WriteToBigTable': 'WriteToBigTable'
+ config:
+ mappings:
+ 'ReadFromBigTable':
+ project: 'project_id'
+ instance: 'instance_id'
+ table: 'table_id'
Review Comment:
let's not expose ReadFromBigtable just yet
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
