y1chi commented on a change in pull request #12815:
URL: https://github.com/apache/beam/pull/12815#discussion_r486672602
##########
File path: sdks/python/apache_beam/dataframe/doctests.py
##########
@@ -319,25 +319,24 @@ def run(self, test, **kwargs):
# Don't fail doctests that raise this error.
example.exc_msg = (
'apache_beam.dataframe.frame_base.WontImplementError: ...')
- self.wont_implement += 1
with self._test_env.context():
result = super(BeamDataframeDoctestRunner, self).run(test, **kwargs)
return result
def report_success(self, out, test, example, got):
def extract_concise_reason(got):
- m = re.search(r"(WontImplementError:.*)\n$", got)
+ m = re.search(r"WontImplementError:\s+(.*)\n$", got)
if m:
return m.group(1)
elif "NameError" in got:
- return "NameError"
+ return "NameError following WontImplementError"
Review comment:
I assume all the errors here are under the precondition that
WontImplementError is seen thus even the regex is not matched we know it is
following WontImplementError?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
