ahmedabu98 commented on code in PR #35649:
URL: https://github.com/apache/beam/pull/35649#discussion_r2231979405
##########
examples/java/src/main/java/org/apache/beam/examples/cookbook/IcebergRestCatalogCDCExample.java:
##########
@@ -201,5 +226,17 @@ public interface IcebergCdcOptions extends GcpOptions {
String getCatalogName();
void setCatalogName(String catalogName);
+
+ @Description("Trigger the streaming write example")
+ @Default.Boolean(false)
+ boolean getTriggerStreamingWrite();
+
+ void setTriggerStreamingWrite(boolean triggerStreamingWrite);
+
+ @Description("The Pub/Sub topic to read from for the streaming write
example")
+ @Default.String("projects/pubsub-public-data/topics/taxirides-realtime")
+ String getTopic();
+
+ void setTopic(String topic);
Review Comment:
nit: This should probably be a static final variable (in
`IcebergRestCatalogStreamingWriteExample`), since the operations we're doing
here rely on the data shape coming from that topic. I think no need to make it
a pipeline option
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
