liferoad commented on code in PR #35672:
URL: https://github.com/apache/beam/pull/35672#discussion_r2233122855
##########
sdks/python/apache_beam/yaml/yaml_provider.py:
##########
@@ -932,6 +932,129 @@ def __init__(self):
# pylint: disable=useless-parent-delegation
super().__init__()
+ def _unify_field_types(self, existing_type, field_type):
+ """Unify two field types, handling Optional and List types."""
+ # Extract inner types from Optional if needed
+ existing_inner = (
+ existing_type.__args__[0] if hasattr(existing_type, '__args__') and
+ len(existing_type.__args__) == 1 else existing_type)
+ field_inner = (
+ field_type.__args__[0] if hasattr(field_type, '__args__') and
+ len(field_type.__args__) == 1 else field_type)
+
+ # Handle type unification more carefully
+ if existing_inner == Any or field_inner == Any:
+ return Optional[Any]
+ elif existing_inner == field_inner:
+ return Optional[existing_inner]
Review Comment:
The current way is to prioritize List, so it should be
Optional[Iterable[str]]. `_unify_element_with_schema` does this conversion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
