Abacn commented on code in PR #35718:
URL: https://github.com/apache/beam/pull/35718#discussion_r2240048547
##########
sdks/java/extensions/sql/src/test/java/org/apache/beam/sdk/extensions/sql/BeamSqlDslSqlStdOperatorsTest.java:
##########
@@ -311,7 +312,7 @@ public void testArithmeticOperator() {
.addExpr("c_double + c_bigint", 2.0)
.addExpr("1 - 1", 0)
.addExpr("1.0 - 1", ZERO_1)
- .addExpr("1 - 0.0", ONE_0)
+ .addExpr("1 - 0.0", ONE_1)
Review Comment:
Yeah there are multiple behavior change like this (see the second commit,
need to adjust assertions). I understand this specific test checks fixed
precision numeric 1 (int) - 0.0 (fixed numeric with 1 decimal point) used to
return 1 (int), now it becomes 1.0 (fixed numeric with 1 decimal point)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
