razvanculea commented on code in PR #35253:
URL: https://github.com/apache/beam/pull/35253#discussion_r2240189504


##########
sdks/python/apache_beam/io/filebasedsink.py:
##########
@@ -385,13 +431,131 @@ def _rename_batch(batch):
       # This error is not serious, we simply log it.
       _LOGGER.info('Unable to delete file: %s', init_result)
 
+  @check_accessible(['file_path_prefix'])
+  def finalize_windowed_write(

Review Comment:
   i agree that it looks the same, I need to double check because as is the 
unit tests fail



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@beam.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to