gemini-code-assist[bot] commented on code in PR #35726: URL: https://github.com/apache/beam/pull/35726#discussion_r2240366905
########## CHANGES.md: ########## @@ -242,6 +244,7 @@ * [Python] GroupIntoBatches may fail in streaming pipelines. This is caused by cloudpickle. To mitigate this issue specify `pickle_library=dill` in pipeline options ([#35062](https://github.com/apache/beam/issues/35062)) * [Python] vLLM breaks dataflow logging. To mitigate this issue, set the `VLLM_CONFIGURE_LOGGING=0` environment variable in your custom container. * [Python] vLLM leaks connections causing a throughput bottleneck and underutilization of GPU. To mitigate this issue increase the number of `number_of_worker_harness_threads`. +* [Java] When using histogram metrics, it can cause spammy logs. Mitigation would be to filter worker start up logs, or upgrade to 2.67.0. Review Comment:  For consistency and clarity, I suggest rephrasing this note. For example, 'start up' is usually written as 'startup', and other known issues in this file use the phrase 'To mitigate this issue...'. ```suggestion * [Java] Using histogram metrics can cause spammy logs. To mitigate this issue, filter worker startup logs, or upgrade to 2.67.0. ``` ########## CHANGES.md: ########## @@ -187,6 +188,7 @@ * (Python) Fixed cloudpickle overwriting class states every time loading a same object of dynamic class ([#35062](https://github.com/apache/beam/issues/35062)). * [Python] Fixed pip install apache-beam[interactive] causes crash on google colab ([#35148](https://github.com/apache/beam/pull/35148)). * [IcebergIO] Fixed Beam <-> Iceberg conversion logic for arrays of structs and maps of structs ([#35230](https://github.com/apache/beam/pull/35230)). +* [Java] When using histogram metrics, it can cause spammy logs. Mitigation would be to filter worker start up logs, or upgrade to 2.67.0. Review Comment:  This note appears to be a 'Known Issue', but it has been placed under the `## Bugfixes` section for version 2.66.0. For consistency with the other changes in this PR, it should be under a `## Known Issues` section. You may need to add this section header for version 2.66.0. Additionally, the wording could be improved for clarity and consistency with other entries. For example, 'start up' is usually written as 'startup', and other entries use the phrase 'To mitigate this issue...'. ```suggestion * [Java] Using histogram metrics can cause spammy logs. To mitigate this issue, filter worker startup logs, or upgrade to 2.67.0. ``` ########## CHANGES.md: ########## @@ -286,6 +289,7 @@ * (Java) Current version of protobuf has a [bug](https://github.com/protocolbuffers/protobuf/issues/20599) leading to incompatibilities with clients using older versions of Protobuf ([example issue](https://github.com/GoogleCloudPlatform/DataflowTemplates/issues/2191)). This issue has been seen in SpannerIO in particular. Tracked in [#34452](https://github.com/GoogleCloudPlatform/DataflowTemplates/issues/34452). * (Java) When constructing `SpannerConfig` for `SpannerIO`, calling `withHost` with a null or empty host will now result in a Null Pointer Exception (`java.lang.NullPointerException: Cannot invoke "java.lang.CharSequence.length()" because "this.text" is null`). See https://github.com/GoogleCloudPlatform/DataflowTemplates/issues/34489 for context. +* [Java] When using histogram metrics, it can cause spammy logs. Mitigation would be to filter worker start up logs, or upgrade to 2.67.0. Review Comment:  For consistency and clarity, I suggest rephrasing this note. For example, 'start up' is usually written as 'startup', and other known issues in this file use the phrase 'To mitigate this issue...'. ```suggestion * [Java] Using histogram metrics can cause spammy logs. To mitigate this issue, filter worker startup logs, or upgrade to 2.67.0. ``` ########## CHANGES.md: ########## @@ -136,6 +136,7 @@ * [YAML] Fixed handling of missing optional fields in JSON parsing ([#35179](https://github.com/apache/beam/issues/35179)). * [Python] Fix WriteToBigQuery transform using CopyJob does not work with WRITE_TRUNCATE write disposition ([#34247](https://github.com/apache/beam/issues/34247)) * [Python] Fixed dicomio tags mismatch in integration tests ([#35658](https://github.com/apache/beam/pull/35658)). +* [Java] - Fixed spammy logging issues that was affecting 2.64.0 to 2.66.0. Review Comment:  This changelog entry has a couple of minor issues: * There's an extra hyphen `-` after `[Java]`, which is inconsistent with other entries in this file. * The grammar "was affecting" is slightly awkward. "affected" or "affecting" would be more appropriate. For improved clarity and consistency, I suggest rephrasing this line. ```suggestion * [Java] Fixed spammy logging issues that affected versions 2.64.0 to 2.66.0. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
