A1K28 opened a new pull request, #35729:
URL: https://github.com/apache/beam/pull/35729
### Description
This PR fixes a flaky test, which is caused by
pandas_doctests_test.py::DoctestTest::test_top_level, that fails intermittently
in CI on Python 3.12.
### Issue
The test fails with an AssertionError: 4 != 0 due to a doctest mismatch.
This occurs because newer versions of numpy, particularly when run on Python
3.12, produce a more explicit string representation for arrays (e.g.,
[np.int32(1)] instead of [1]).
### Solution
The project's custom _DeferrredDataframeOutputChecker already contains logic
to normalize these string representations. However, this logic was incorrectly
guarded by a version check:
```Python
if sys.version_info < (3, 11) and 'NumpyExtensionArray' in got:
# ... normalization logic ...
```
This prevented the fix from running on Python 3.12 environments. This PR
removes the obsolete sys.version_info < (3, 11) condition, allowing the output
normalization to run on all Python versions and resolving the test failure.
### Verification
I have verified this fix locally by:
Creating a clean environment using Python 3.12.10 to reliably reproduce the
AssertionError.
Applying this code change, which caused the test to pass consistently in the
same Python 3.12.10 environment.
This change makes our doctests more resilient to environmental differences.
Related Issue: Fixes #35691
Related PR:
------------------------
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example:
`addresses #123`), if applicable. This will automatically add a link to the
pull request in the issue. If you would like the issue to automatically close
on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more
tips on [how to make review process
smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier).
To check the build health, please visit
[https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more
information about GitHub Actions CI or the [workflows
README](https://github.com/apache/beam/blob/master/.github/workflows/README.md)
to see a list of phrases to trigger workflows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
