mohamedawnallah commented on code in PR #35733: URL: https://github.com/apache/beam/pull/35733#discussion_r2241456754
########## sdks/python/scripts/run_pytest.sh: ########## @@ -62,16 +81,60 @@ if [[ -n $user_marker ]]; then marker_for_sequential_tests="($user_marker) and ($marker_for_sequential_tests)" fi +# Parse posargs to separate pytest options from test paths. +options="" +test_paths="" + +# Safely split the posargs string into individual arguments. +eval "set -- $posargs" Review Comment: @gemini-code-assist Other alternatives would result in adding more complexity to this script in terms of looping through tokens, handling quotes, ...etc. Also `run_pytest.sh` run by CI environments and there minimal change happen to them and reviewed so not sure if it is considered "critical". I will leave it as is unless other reviewer has another opinion on it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
