mohamedawnallah commented on code in PR #35733: URL: https://github.com/apache/beam/pull/35733#discussion_r2242723696
########## sdks/python/scripts/run_pytest.sh: ########## @@ -62,16 +81,60 @@ if [[ -n $user_marker ]]; then marker_for_sequential_tests="($user_marker) and ($marker_for_sequential_tests)" fi +# Parse posargs to separate pytest options from test paths. +options="" +test_paths="" + +# Safely split the posargs string into individual arguments. +eval "set -- $posargs" Review Comment: @gemini-code-assist We can do this change in follow-up PR? Bash is tricky and take me a bit of time to test them. I can say I am confident that current changes `eval "set -- $posargs"` work functionally non functionally in terms of security as you said not. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
