liferoad commented on code in PR #35774:
URL: https://github.com/apache/beam/pull/35774#discussion_r2249263183
##########
sdks/python/apache_beam/yaml/yaml_ml.py:
##########
@@ -514,11 +509,36 @@ def ml_transform(
options.YamlOptions.check_enabled(pcoll.pipeline, 'ML')
# TODO(robertwb): Perhaps _config_to_obj could be pushed into MLTransform
# itself for better cross-language support?
- return pcoll | MLTransform(
+ result = pcoll | MLTransform(
write_artifact_location=write_artifact_location,
read_artifact_location=read_artifact_location,
transforms=[_config_to_obj(t) for t in transforms] if transforms else [])
+ if transforms and any(t.get('type') == 'SentenceTransformerEmbeddings'
+ for t in transforms):
Review Comment:
this is ugly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
