shunping commented on code in PR #35770:
URL: https://github.com/apache/beam/pull/35770#discussion_r2249506597
##########
sdks/go/pkg/beam/runners/prism/internal/engine/elementmanager.go:
##########
@@ -1920,8 +1923,18 @@ func (ss *stageState) splitBundle(rb RunBundle,
firstResidual int) {
res := es.es[firstResidual:]
es.es = prim
- ss.pending = append(ss.pending, res...)
- heap.Init(&ss.pending)
+
+ for _, e := range res {
+ delete(ss.inprogressKeysByBundle[rb.BundleID],
string(e.keyBytes))
+ delete(ss.inprogressKeys, string(e.keyBytes))
+
+ if e.IsTimer() {
Review Comment:
Since we should no longer call splitBundle on a bundle with timers, maybe we
can also get rid of the code for handling holds here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
