tvalentyn commented on PR #35656: URL: https://github.com/apache/beam/pull/35656#issuecomment-3148347023
Re lint errors: Let's fix ones that are fixable, e.g. line-too-long? and disable the other ones, see examples: https://github.com/search?q=repo%3Aapache%2Fbeam%20%22%23%20pylint%3A%20disable%3D%22&type=code ``` Running pylint... ************* Module apache_beam.internal.code_object_pickler_test apache_beam/internal/code_object_pickler_test.py:135:0: C0301: Line too long (89/80) (line-too-long) apache_beam/internal/code_object_pickler_test.py:154:0: C0301: Line too long (81/80) (line-too-long) apache_beam/internal/code_object_pickler_test.py:181:0: C0301: Line too long (81/80) (line-too-long) ************* Module apache_beam.internal.pickle_code_path_test apache_beam/internal/pickle_code_path_test.py:36:0: W0611: Unused module_with_default_argument imported from apache_beam.internal.test_cases (unused-import) ************* Module apache_beam.internal.test_cases.after_module_with_nested_function apache_beam/internal/test_cases/after_module_with_nested_function.py:22:2: W0612: Unused variable 'a' (unused-variable) apache_beam/internal/test_cases/after_module_with_nested_function.py:25:2: W0612: Unused variable 'nested_function' (unused-variable) ************* Module apache_beam.internal.test_cases.after_module_with_classes apache_beam/internal/test_cases/after_module_with_classes.py:23:4: W0612: Unused variable 'a' (unused-variable) apache_beam/internal/test_cases/after_module_with_classes.py:25:4: W0612: Unused variable 'new_local_variable' (unused-variable) apache_beam/internal/test_cases/after_module_with_classes.py:37:4: W0612: Unused variable 'a' (unused-variable) apache_beam/internal/test_cases/after_module_with_classes.py:39:4: W0612: Unused variable 'c' (unused-variable) apache_beam/internal/test_cases/after_module_with_classes.py:51:4: W0612: Unused variable 'nested_function' (unused-variable) apache_beam/internal/test_cases/after_module_with_classes.py:55:4: W0612: Unused variable 'a' (unused-variable) apache_beam/internal/test_cases/after_module_with_classes.py:62:4: W0612: Unused variable 'a' (unused-variable) apache_beam/internal/test_cases/after_module_with_classes.py:65:4: W0612: Unused variable 'nested_function' (unused-variable) apache_beam/internal/test_cases/after_module_with_classes.py:74:4: W0612: Unused variable 'a' (unused-variable) apache_beam/internal/test_cases/after_module_with_classes.py:79:4: W0612: Unused variable 'a' (unused-variable) apache_beam/internal/test_cases/after_module_with_classes.py:86:4: W0612: Unused variable 'a' (unused-variable) ************* Module apache_beam.internal.test_cases.after_module_with_single_class apache_beam/internal/test_cases/after_module_with_single_class.py:23:4: W0612: Unused variable 'a' (unused-variable) apache_beam/internal/test_cases/after_module_with_single_class.py:29:2: W0612: Unused variable 'a' (unused-variable) ************* Module apache_beam.internal.test_cases.before_module_with_functions apache_beam/internal/test_cases/before_module_with_functions.py:22:2: W0612: Unused variable 'a' (unused-variable) ************* Module apache_beam.internal.test_cases.after_module_add_lambda_variable apache_beam/internal/test_cases/after_module_add_lambda_variable.py:22:2: W0612: Unused variable 'a' (unused-variable) apache_beam/internal/test_cases/after_module_add_lambda_variable.py:24:2: W0612: Unused variable 'new_lambda_variable' (unused-variable) ************* Module apache_beam.internal.test_cases.after_module_with_global_variable apache_beam/internal/test_cases/after_module_with_global_variable.py:24:2: W0612: Unused variable 'a' (unused-variable) ************* Module apache_beam.internal.test_cases.after_module_with_nested_function_2 apache_beam/internal/test_cases/after_module_with_nested_function_2.py:22:2: W0612: Unused variable 'nested_function' (unused-variable) apache_beam/internal/test_cases/after_module_with_nested_function_2.py:26:2: W0612: Unused variable 'a' (unused-variable) ************* Module apache_beam.internal.test_cases.after_module_add_function apache_beam/internal/test_cases/after_module_add_function.py:22:2: W0612: Unused variable 'a' (unused-variable) apache_beam/internal/test_cases/after_module_add_function.py:28:2: W0612: Unused variable 'a' (unused-variable) ************* Module apache_beam.internal.test_cases.before_module_with_lambdas apache_beam/internal/test_cases/before_module_with_lambdas.py:22:2: W0612: Unused variable 'a' (unused-variable) ************* Module apache_beam.internal.test_cases.before_module_with_classes apache_beam/internal/test_cases/before_module_with_classes.py:23:4: W0612: Unused variable 'a' (unused-variable) apache_beam/internal/test_cases/before_module_with_classes.py:30:4: W0612: Unused variable 'a' (unused-variable) apache_beam/internal/test_cases/before_module_with_classes.py:37:4: W0612: Unused variable 'a' (unused-variable) apache_beam/internal/test_cases/before_module_with_classes.py:44:4: W0612: Unused variable 'a' (unused-variable) apache_beam/internal/test_cases/before_module_with_classes.py:51:4: W0612: Unused variable 'a' (unused-variable) apache_beam/internal/test_cases/before_module_with_classes.py:58:4: W0612: Unused variable 'a' (unused-variable) apache_beam/internal/test_cases/before_module_with_classes.py:65:4: W0612: Unused variable 'a' (unused-variable) apache_beam/internal/test_cases/before_module_with_classes.py:72:4: W0612: Unused variable 'a' (unused-variable) apache_beam/internal/test_cases/before_module_with_classes.py:77:4: W0612: Unused variable 'a' (unused-variable) ************* Module apache_beam.internal.test_cases.after_module_add_variable apache_beam/internal/test_cases/after_module_add_variable.py:22:2: W0612: Unused variable 'a' (unused-variable) apache_beam/internal/test_cases/after_module_add_variable.py:24:2: W0612: Unused variable 'new_local_variable' (unused-variable) ------------------------------------ Your code has been rated at 10.00/10 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
