Abacn commented on code in PR #35792:
URL: https://github.com/apache/beam/pull/35792#discussion_r2257369601
##########
sdks/python/apache_beam/yaml/yaml_provider.py:
##########
@@ -383,23 +384,41 @@ def __init__(
self._jar_provider = jar_provider
self._classpath = classpath
+
def available(self):
# pylint: disable=subprocess-run-check
- trial = subprocess.run(['which', subprocess_server.JavaHelper.get_java()],
Review Comment:
We should fix `subprocess_server.JavaHelper.get_java()` to support windows.
This approach effectively removed JAVA_HOME environment handling that was
considered there and affects all platforms, and leads to inconsistent result
for available() and jar_provider call
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
