lukecwik commented on pull request #12617: URL: https://github.com/apache/beam/pull/12617#issuecomment-691375678
> Hi @lukecwik , I must miss some context here, could you help me understand couple of things: > > 1. If the PR is intended to opt Samza runner out for SplittableDoFn, why do we also introduce the translator for it? In this case the opt-out means that the user must manually specify "use_deprecated_read" to opt-out of using SplittableDoFn as SplittableDoFn will be the default. > 2. `beam:transform:sdf_process_keyed_elements:v1` seems to be deprecated, are we expected to translate this urn/transform? This is deprecated since this represents a URN that doesn't exist in the portable pipeline representation and never will. It is an artifact of how some non-portable runners do transform replacement. > 3. where are setting `--experiments=use_deprecated_read` for Samza runner to opt out? We aren't, this change makes Samza use SplittableDoFn by default and the user must specify `--experiments=use_deprecated_read` to not use it. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
