jayendra13 commented on a change in pull request #12540:
URL: https://github.com/apache/beam/pull/12540#discussion_r487353928
##########
File path:
sdks/java/io/common/src/test/java/org/apache/beam/sdk/io/common/IOTestPipelineOptions.java
##########
@@ -45,19 +45,16 @@
void setBigQueryTable(@Nullable String tableName);
@Description("InfluxDB measurement to publish results to.")
- @Nullable
String getInfluxMeasurement();
void setInfluxMeasurement(@Nullable String measurement);
@Description("InfluxDB host.")
- @Nullable
String getInfluxHost();
void setInfluxHost(@Nullable String host);
@Description("InfluxDB database.")
- @Nullable
Review comment:
I removed those nullable as it was expecting these fields non-null
[here](https://github.com/jayendra13/beam/blob/10620/sdks/java/testing/test-utils/src/main/java/org/apache/beam/sdk/testutils/publishing/InfluxDBSettings.java#L31)
via,
[this](https://github.com/jayendra13/beam/blob/10620/sdks/java/extensions/sql/perf-tests/src/test/java/org/apache/beam/sdk/extensions/sql/meta/provider/bigquery/BigQueryIOPushDownIT.java#L114).
I removed the `Nullable` from here thinking of it as a test code and
[InfluxDBSettings.java](https://github.com/jayendra13/beam/blob/10620/sdks/java/testing/test-utils/src/main/java/org/apache/beam/sdk/testutils/publishing/InfluxDBSettings.java)
as a non-test code.
Annotating the corresponding fields at
[InfluxDBSettings.java](https://github.com/jayendra13/beam/blob/10620/sdks/java/testing/test-utils/src/main/java/org/apache/beam/sdk/testutils/publishing/InfluxDBSettings.java)
as `Nullable` also should work.
Should I go with that?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
