A1K28 commented on code in PR #35809:
URL: https://github.com/apache/beam/pull/35809#discussion_r2266995897
##########
sdks/python/test-suites/dataflow/common.gradle:
##########
@@ -459,7 +459,7 @@ def vllmTests = tasks.create("vllmTests") {
// TODO(https://github.com/apache/beam/issues/22651): Build docker image
for VLLM tests during Run time.
// This would also enable to use wheel "--sdk_location" as other tasks,
and eliminate distTarBall dependency
// declaration for this project.
- // Right now, this is built from
https://github.com/apache/beam/blob/master/sdks/python/apache_beam/ml/inference/test_resources/vllm.dockerfile
+ // Right now, this is built from
https://github.com/apache/beam/blob/master/sdks/python/apache_beam/ml/inference/test_resources/vllm.dockerfile.old
Review Comment:
A new image is built on every workflow, which is then stored in artifact
registry that deletes them after 12 hours, to avoid clutter. Would you like me
to build an image by hand and statically point the address there? although, i'd
advise against that, as it would later on introduce runtime errors. More
specifically, as beam versions progress, the dataflow workers will no longer be
able to boot.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
