mohamedawnallah commented on code in PR #34398:
URL: https://github.com/apache/beam/pull/34398#discussion_r2279981586
##########
.github/workflows/beam_PreCommit_Python_Transforms.yml:
##########
@@ -53,7 +53,6 @@ env:
DEVELOCITY_ACCESS_KEY: ${{ secrets.DEVELOCITY_ACCESS_KEY }}
GRADLE_ENTERPRISE_CACHE_USERNAME: ${{ secrets.GE_CACHE_USERNAME }}
GRADLE_ENTERPRISE_CACHE_PASSWORD: ${{ secrets.GE_CACHE_PASSWORD }}
- ALLOYDB_PASSWORD: ${{ secrets.ALLOYDB_PASSWORD }}
Review Comment:
> Was removing this intentional?
Yes, This was introduced as prequisite of this PR but turned out it produces
weird issues here
https://github.com/apache/beam/pull/34398#issuecomment-3051520645 (not figured
out what was the main issue was) but there will be no issue removing this and
we don't miss running those tests since those would eventually run in
postcommit python
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
