arunpandianp commented on code in PR #35901:
URL: https://github.com/apache/beam/pull/35901#discussion_r2283951080
##########
runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/options/DataflowStreamingPipelineOptions.java:
##########
@@ -310,6 +310,9 @@ public Integer create(PipelineOptions options) {
class EnableWindmillServiceDirectPathFactory implements
DefaultValueFactory<Boolean> {
@Override
public Boolean create(PipelineOptions options) {
+ if (ExperimentalOptions.hasExperiment(options,
"enable_windmill_service_direct_path=false")) {
Review Comment:
It is odd that "enable_windmill_service_direct_path=false" and
"enable_windmill_service_direct_path" works, but
"enable_windmill_service_direct_path=true" doesn't.
Can we make "enable_windmill_service_direct_path=true" work? Or we could use
`disable_windmill_service_direct_path` to disable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
