jrmccluskey commented on code in PR #35677:
URL: https://github.com/apache/beam/pull/35677#discussion_r2285589582


##########
sdks/python/apache_beam/ml/transforms/embeddings/vertex_ai.py:
##########
@@ -281,3 +294,194 @@ def get_ptransform_for_processing(self, **kwargs) -> 
beam.PTransform:
     return RunInference(
         model_handler=_ImageEmbeddingHandler(self),
         inference_args=self.inference_args)
+
+
+@dataclass
+class VertexAIMultiModalInput:
+  image: Optional[Image] = None
+  video: Optional[Video] = None
+  contextual_text: Optional[str] = None

Review Comment:
   I shifted video to use a relatively simple tuple wrapper to make (`Video`, 
`VideoSegmentConfig`) pairs based on the doc discussion. I don't know how much 
sense it makes to wrap every field in this object since images and text do not 
have configuration objects associated with them; should this change, we can 
always update things on our end. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@beam.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to