hjtran commented on code in PR #35881: URL: https://github.com/apache/beam/pull/35881#discussion_r2287952809
########## sdks/python/apache_beam/transforms/core_test.py: ########## @@ -162,6 +162,14 @@ def test_dofn_with_implicit_return_none_return_without_value(self): class PartitionTest(unittest.TestCase): + def test_partition_with_bools(self): + with pytest.raises( + Exception, + match="PartitionFn yielded a 'bool' when it should only yields integers" + ): Review Comment: I initially checked for ValueError and the test works with the directrunner but the portable runner will cast all exceptions to RuntimeError. (https://github.com/apache/beam/runs/48183396870) I can narrow this to check for either `RuntimeError` or `ValueError` though -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
