ahmedabu98 commented on code in PR #35913:
URL: https://github.com/apache/beam/pull/35913#discussion_r2288476884
##########
sdks/python/apache_beam/transforms/trigger.py:
##########
@@ -317,6 +317,17 @@ def from_runner_api(proto, context):
def to_runner_api(self, unused_context):
pass
+ @abstractmethod
+ def get_continuation_trigger(self):
+ """Returns:
+ Tigger to use after a GroupBy to preserve the intention of this
trigger.
+ Specifically, triggers that are time based and intended to provide
+ speculative results should continue providing speculative results.
+ Triggers that fire once (or multiple times) should continue firing
+ once (or multiple times).
+ """
+ pass
Review Comment:
Does it make sense to default this to `return self` ?
I'm wondering if this can break existing custom (user) Triggers
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
