mohamedawnallah commented on PR #35884: URL: https://github.com/apache/beam/pull/35884#issuecomment-3211189428
@vijay-x-Raj – The formatter CI pipeline passed now 🎉 The linter failing with this err (from publicly available CI logs) ``` apache_beam/ml/anomaly/detectors/pyod_adapter.py:142: error: Argument 1 to "OfflineDetector" has incompatible type "ModelHandler[tuple[Any, Row], tuple[Any, AnomalyPrediction], Union[Any, _ModelManager]]"; expected "KeyedModelHandler[Any, Row, Never, Any]" [arg-type] apache_beam/ml/anomaly/detectors/pyod_adapter.py:145: error: Unused "type: ignore" comment [unused-ignore] Found 2 errors in 1 file (checked 1334 source files) error: mypy exited with status 1 ``` It is okay. It takes a bit of time to go through the process of fixing linting issues especially on first contributions. You can fix this and perhaps you can test it utilizing `.pylintrc` and `mypy.ini` (don't remember the exact command to run against those files but those I think can be easily found online). This can give you a fast iteration of feedback locally instead of (fix an issue that cause the linting to fail -> push to CI -> async waiting for CI to finish -> oops there are still CI linting issues -> loop). https://github.com/apache/beam/blob/master/sdks/python/.pylintrc https://github.com/apache/beam/blob/master/sdks/python/mypy.ini -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
