nyoungstudios commented on PR #35564: URL: https://github.com/apache/beam/pull/35564#issuecomment-3218188145
Thanks @damccorm for the review. Sorry for the delayed response as I got busy with other things. Obviously, I am not an active contributor here; so, if you guys don't think this is worth adding then that is fine with me. I will say that even though this repo does have linting for Python, my updates in this pr showed that the current tools being used still miss some whitespace. If I were a code reviewer where there could be inconsistency in whitespace, I would fine that annoying. But I don't really mind that much since I am not a code reviewer here. I will say that my biggest complaint when first contributing Python code to this repo is that it uses 2 spaces for a tab opposed to most Python projects and Python IDEs that default to 4 spaces. With that in mind, do you think I could make this pr (or open another pr) for just the `.editorconfig` file change? Lots of other popular repos on GitHub use an `.editorconifg` file like [Apache Airflow](https://github.com/apache/airflow/blob/main/.editorconfig), [React](https://github.com/facebook/react/blob/main/.editorconfig), [Django](https://github.com/django/django/blob/main/.editorconfig), and [VS Code](https://github.com/microsoft/vscode/blob/main/.editorconfig). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
