A1K28 commented on PR #35920:
URL: https://github.com/apache/beam/pull/35920#issuecomment-3219415937
> > Hm, I see the following error logs in the postcommit python:
> > ```
> > <testcase
classname="apache_beam.ml.rag.enrichment.milvus_search_it_test.TestMilvusSearchEnrichment"
name="test_empty_input_chunks" time="26.780">
> > <error message="failed on setup with
"pymilvus.exceptions.MilvusException: <MilvusException: (code=2, message=Fail
connecting to server on 172.17.0.2:51635, illegal connection params or server
unavailable)>"">cls = <class
'apache_beam.ml.rag.enrichment.milvus_search_it_test.TestMilvusSearchEnrichment'>
@classmethod def setUpClass(cls): cls._db =
MilvusEnrichmentTestHelper.start_db_container(cls._version)
cls._connection_params = MilvusConnectionParameters( uri=cls._db.uri,
user=cls._db.user, password=cls._db.password, db_id=cls._db.id,
token=cls._db.token) cls._collection_load_params =
MilvusCollectionLoadParameters() > cls._collection_name =
MilvusEnrichmentTestHelper.initialize_db_with_data( cls._connection_params)
apache_beam/ml/rag/enrichment/milvus_search_it_test.py:496: _ _ _ _ _ _ _ _ _ _
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
apache_beam/ml/rag/enrichment/milvus_search_it_test.py:365: in
initialize_db_with_data client = MilvusClient(**connc_params.
__dict__)
target/.tox-py39-cloudcoverage/py39-cloudcoverage/lib/python3.9/site-packages/pymilvus/milvus_client/milvus_client.py:64:
in __init__ self._using = create_connection(
target/.tox-py39-cloudcoverage/py39-cloudcoverage/lib/python3.9/site-packages/pymilvus/milvus_client/_utils.py:49:
in create_connection raise ex from ex
target/.tox-py39-cloudcoverage/py39-cloudcoverage/lib/python3.9/site-packages/pymilvus/milvus_client/_utils.py:44:
in create_connection connections.connect(
target/.tox-py39-cloudcoverage/py39-cloudcoverage/lib/python3.9/site-packages/pymilvus/orm/connections.py:459:
in connect connect_milvus(**kwargs, user=user, password=password, token=token,
db_name=db_name)
target/.tox-py39-cloudcoverage/py39-cloudcoverage/lib/python3.9/site-packages/pymilvus/orm/connections.py:420:
in connect_milvus raise e from e
target/.tox-py39-cloudcoverage/py39-cloudcoverage/lib/python3.9/site-packages/pymilvus/orm/connections.py:412:
in connect_milvus gh._wait_for_channel_ready(tim
eout=timeout) _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
_ _ _ _ _ _ _ _ self = <pymilvus.client.grpc_handler.GrpcHandler object at
0x7cdbb04fed30> timeout = 10.0 def _wait_for_channel_ready(self, timeout:
Union[float] = 10): if self._channel is None: raise MilvusException(
code=Status.CONNECT_FAILED, message="No channel in handler, please setup grpc
channel first", ) try:
grpc.channel_ready_future(self._channel).result(timeout=timeout)
self._setup_identifier_interceptor(self._user, timeout=timeout) except
grpc.FutureTimeoutError as e: self.close() > raise MilvusException(
code=Status.CONNECT_FAILED, message=f"Fail connecting to server on
{self._address}, illegal connection params or server unavailable", ) from e E
pymilvus.exceptions.MilvusException: <MilvusException: (code=2, message=Fail
connecting to server on 172.17.0.2:51635, illegal connection params or server
unavailable)>
target/.tox-py39-cloudcoverage/py39-cloudcoverage/lib/python3.9/site-packages/pymi
lvus/client/grpc_handler.py:159: MilvusException</error>
> > </testcase>
> > ```
> >
> >
> >
> >
> >
> >
> >
> >
> >
> >
> >
> > Could you please take a look?
>
> @damccorm - The root cause of this because of changing milvus server
version in the integration tests from `v2.5.10`to `v2.3.9` in that PR #35889.
This is not aligned with our pymilvus dependency in `sdk/python/setup.py`:
`'pymilvus>=2.5.10,<3.0.0'`
>
> @A1K28 Could please elaborate more about the rational behind this change?
I see the note there in PR description `Downgrades milvus version to account
for CPU instability` and I am not sure I am able to get this
>
> With a note as well if we decided to downgrade that we will lose nice
features like BM25 Metric Type. Seeing: [milvus-io/milvus#39652
(comment)](https://github.com/milvus-io/milvus/issues/39652#issuecomment-2638405107)
Yes, feel free to revert that specific change. The reason for it was:
"Your CPU must support one of the following instruction sets to run Milvus:
SSE4. 2, AVX, AVX2, AVX512.". Retrieved from
https://milvus.io/docs/v2.4.x/product_faq.md. Some of my self hosted runners
were screaming about that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
