derrickaw commented on code in PR #35952:
URL: https://github.com/apache/beam/pull/35952#discussion_r2301797742
##########
sdks/python/apache_beam/yaml/json_utils.py:
##########
@@ -287,8 +287,9 @@ def row_to_json(beam_type: schema_pb2.FieldType) ->
Callable[[Any], Any]:
for field in beam_type.row_type.schema.fields
}
return lambda row: {
- name: convert(getattr(row, name))
+ name: converted
for (name, convert) in converters.items()
+ if (converted := convert(getattr(row, name, None))) is not None
Review Comment:
I was running through many scenarios during development and ran into an
issue with this, but I don't think its needed anymore. Good catch. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
