shunping commented on PR #35964: URL: https://github.com/apache/beam/pull/35964#issuecomment-3226556891
Thanks @lostluck ! Could you take another look at the PR? To make the fix clear, I have removed the previous debug logging and the segv fix, and will move them to a different PR. In addition, I also take care of the external environment with the help of an environment variable mentioned in our doc https://beam.apache.org/documentation/runtime/sdk-harness-config/ That environment variable is also used at https://github.com/apache/beam/blob/4c5cadad5a7924cd1c19f3499b7724669acc8da7/runners/java-fn-execution/src/main/java/org/apache/beam/runners/fnexecution/environment/ExternalEnvironmentFactory.java#L49 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
