LEEKYE commented on code in PR #35391:
URL: https://github.com/apache/beam/pull/35391#discussion_r2304331044


##########
sdks/python/apache_beam/runners/worker/sdk_worker_main.py:
##########
@@ -219,6 +224,14 @@ def main(unused_argv):
       fn_log_handler.close()
 
 
+def flush_fn_log_handler():
+  """Flushes the FnApiLogRecordHandler if it exists."""
+  _LOGGER.error('The Sdk harness will be terminated now.')

Review Comment:
   DONE



##########
sdks/python/apache_beam/runners/worker/worker_status.py:
##########
@@ -252,12 +257,8 @@ def _log_lull_in_bundle_processor(self, 
bundle_process_cache):
             self._log_lull_sampler_info(info, instruction)
 
   def _log_lull_sampler_info(self, sampler_info, instruction):
-    if not self._passed_lull_timeout_since_last_log():
-      return
-    if (sampler_info and sampler_info.time_since_transition and
-        sampler_info.time_since_transition > self.log_lull_timeout_ns):
+    if (sampler_info and sampler_info.time_since_transition):

Review Comment:
   DONE



##########
sdks/python/apache_beam/runners/worker/sdk_worker_main.py:
##########
@@ -219,6 +224,14 @@ def main(unused_argv):
       fn_log_handler.close()
 
 
+def flush_fn_log_handler():
+  """Flushes the FnApiLogRecordHandler if it exists."""
+  _LOGGER.error('The Sdk harness will be terminated now.')
+  if _FN_LOG_HANDLER:
+    _FN_LOG_HANDLER.close()
+  os._exit(1)

Review Comment:
   DONE



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to