shunping commented on code in PR #35977:
URL: https://github.com/apache/beam/pull/35977#discussion_r2304566687
##########
sdks/go/pkg/beam/runners/prism/internal/environments.go:
##########
@@ -273,6 +275,7 @@ func dockerEnvironment(ctx context.Context, logger
*slog.Logger, dp *pipepb.Dock
rc, err := cli.ContainerLogs(bgctx, containerID,
container.LogsOptions{Details: true, ShowStdout: true, ShowStderr: true})
if err != nil {
logger.Error("docker container logs error",
"error", err)
+ return
}
defer rc.Close()
Review Comment:
This is where the segv happens (at line 280) if we don't have the "return"
above. Particularly, `rc` could be `nil` if an error is returned from
`cli.ContainerLogs`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
