damccorm commented on code in PR #35725:
URL: https://github.com/apache/beam/pull/35725#discussion_r2304953128
##########
sdks/python/apache_beam/coders/coders.py:
##########
@@ -180,7 +180,8 @@ def is_deterministic(self):
"""
return False
- def as_deterministic_coder(self, step_label, error_message=None):
+ def as_deterministic_coder(
+ self, step_label, error_message=None, update_compatibility_version=None):
Review Comment:
Will this break any custom coders that define `as_deterministic_coder`? If
so, one option would be to define a function in the base class which takes in
these args but just shells out to `as_deterministic_coder` by default
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
