mohamedawnallah commented on code in PR #35954:
URL: https://github.com/apache/beam/pull/35954#discussion_r2305172484
##########
.github/workflows/beam_PreCommit_Python_Coverage.yml:
##########
@@ -110,6 +120,12 @@ jobs:
uses: ./.github/actions/gradle-command-self-hosted-action
with:
gradle-command: :sdks:python:test-suites:tox:py39:preCommitPyCoverage
+ arguments: |
+ -Pposargs="${{
+ contains(matrix.os, 'self-hosted') &&
+ '-m (not require_docker_in_docker)' ||
+ '-m require_docker_in_docker'
Review Comment:
I would recommend including this with
https://github.com/apache/beam/pull/35920 so that:
👍
##########
.github/workflows/beam_PreCommit_Python_Coverage.yml:
##########
@@ -110,6 +120,12 @@ jobs:
uses: ./.github/actions/gradle-command-self-hosted-action
with:
gradle-command: :sdks:python:test-suites:tox:py39:preCommitPyCoverage
+ arguments: |
+ -Pposargs="${{
+ contains(matrix.os, 'self-hosted') &&
+ '-m (not require_docker_in_docker)' ||
+ '-m require_docker_in_docker'
Review Comment:
> I would recommend including this with
https://github.com/apache/beam/pull/35920 so that:
👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
