scwhittle commented on issue #35990:
URL: https://github.com/apache/beam/issues/35990#issuecomment-3232768630

   The default implementation in beam python doesn't actually do anything.
   
https://github.com/apache/beam/blob/master/sdks/python/apache_beam/io/gcp/pubsub.py#L544C13-L544C18
   This is https://github.com/apache/beam/issues/27443
   
   Direct runner has a specialized implementation that actually publishes.
   
   And Dataflow Streaming specializes pubsub input/output as well.
   
   But that leaves no actual publishing occurring for Dataflow Batch or other 
runners.
   
   I think that we should just promote the direct runner implementation to be 
the default implementation. 
   
https://github.com/apache/beam/blob/master/sdks/python/apache_beam/runners/direct/direct_runner.py#L522
   
   
   Dataflow streaming can still override.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@beam.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to