derrickaw commented on PR #34992: URL: https://github.com/apache/beam/pull/34992#issuecomment-3233962749
Hi @Ashfaqbs, 1. I understand that failure is expected in this code situation, but we can't leave it like that and will need to address it in either of two ways - a) do what Robert suggested [here](https://github.com/apache/beam/pull/34992#issuecomment-2913225173) with not testing this particular example or b) update this example to match something [like](https://github.com/apache/beam/blob/master/sdks/python/apache_beam/yaml/examples/transforms/io/kafka.yaml). My preference is the latter option (you can use Charles's [PR](https://github.com/apache/beam/pull/35151/files) for a go by), so that all the examples that we have are tested. 2. We should also move your example to this [location](https://github.com/apache/beam/tree/master/sdks/python/apache_beam/yaml/examples/transforms/io). Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
