LEEKYE commented on code in PR #36003:
URL: https://github.com/apache/beam/pull/36003#discussion_r2310303321
##########
sdks/go/pkg/beam/core/metrics/sampler.go:
##########
@@ -67,7 +67,7 @@ func (s *StateSampler) Sample(ctx context.Context, t
time.Duration) error {
s.nextLogTime += s.logInterval
}
if s.restartLullTimeout > 0 && s.millisSinceLastTransition >
s.restartLullTimeout {
- return errors.Errorf("Operation ongoing in transform %v
for at least %v ms without outputting or completing in state %v, the SDK
harness will be terminated and restarted", ps.pid, s.millisSinceLastTransition,
getState(ps.state))
+ return errors.Errorf("Processing of an element in
transform %v has exceeded the specified timeout of %v ms without outputting or
completing in state %v, SDK harness will be terminated", ps.pid,
s.restartLullTimeout, getState(ps.state))
Review Comment:
Yes, it means milliseconds and it's correct, I use milliseconds for
consistency
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
